fix(l10n): client-rendered strings always in en-US#1369
Merged
Conversation
LeoMcA
changed the title
Contributor
|
e9334ac was deployed to: https://fred-pr1369.review.mdn.allizom.net/ |
caugner
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #1367.
Currently strings rendered on the client - so this is strings within custom elements which aren't SSRed - always render in en-US. This is because our entry-points race in an unexpected way, which we do need to fix, but has some drawbacks/considerations we need to make. I've got a draft PR for that I need to spend more time on tomorrow: #1368
For now, we can and should fix the worst of the issue for localised strings by not caching the miss. This PR does that.
An example of the issue can be seen on https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Global_Objects/Array/Array#compatibilit%C3%A9_des_navigateurs:
Before:
After: