fix(content-section): missing iframe styling#1414
Open
Conversation
Fixes the iframe border issue by adding a style to server.css
Fixes mdn#1353 iframe has a thick default border (missing styling)
Author
|
hi @caugner, just wanted to draw your attention to ask if this PR can be reviewed please? |
LeoMcA
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue was for an unstyled iframe border. I have added styles for the "iframe" tag under a parent content container.
Motivation
This added style in server.css addes minimal styles to have consistent styling for iframes with respect to other container elements on the page. The original issue that was reported expected uniform styling as the goal and this MR achieves it.
Additional details
Here are the slugs of all the pages that had unstyled iframes contributing to the unoptimal user experience and have been fixed.
/Related/IMSC
/MDN/Writing_guidelines/Page_structures/Code_examples
/Related/IMSC/Basics
/Related/IMSC/Styling
/Related/IMSC/Subtitle_placement
/Related/IMSC/Using_the_imscJS_polyfill
/Web/API/CSS_Painting_API/Guide
/Web/API/ManagedMediaSource
/Web/API/Web_components/Using_shadow_DOM
/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
/Web/API/WebGL_API/Tutorial/Animating_objects_with_WebGL
/Web/API/WebGL_API/Tutorial/Animating_textures_in_WebGL
/Web/API/WebGL_API/Tutorial/Creating_3D_objects_using_WebGL
/Web/API/WebGL_API/Tutorial/Getting_started_with_WebGL
/Web/API/WebGL_API/Tutorial/Lighting_in_WebGL
/Web/API/WebGL_API/Tutorial/Using_shaders_to_apply_color_in_WebGL
/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
/Web/CSS/Guides/Backgrounds_and_borders/Border-image_generator
/Web/CSS/Guides/Backgrounds_and_borders/Border-radius_generator
/Web/CSS/Guides/Backgrounds_and_borders/Box-shadow_generator
/Web/CSS/Guides/Colors
/Web/CSS/Reference/Values/color_value/color-mix
/Web/HTML/Reference/Elements/template
/Web/Media/Guides/Audio_and_video_manipulation
Related issues and pull requests
🔨 #1353