Skip to content

[MCC-1476014] Python Lib-Create Fetch_data() function#15

Closed
afieraru-mdsol wants to merge 2 commits into
mainfrom
feat/MCC-1476014-2
Closed

[MCC-1476014] Python Lib-Create Fetch_data() function#15
afieraru-mdsol wants to merge 2 commits into
mainfrom
feat/MCC-1476014-2

Conversation

@afieraru-mdsol

Copy link
Copy Markdown
Contributor

feature/bug/enhance/refactor/tech_debt/hotfix

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

  • Create fetch_data() function

Copilot AI review requested due to automatic review settings May 4, 2026 13:16
@afieraru-mdsol
afieraru-mdsol marked this pull request as draft May 4, 2026 13:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new/updated fetch_data() API on DataConnectClient intended to retrieve dataset data via Arrow Flight DoGet and return results as a pandas DataFrame, with optional row limiting.

Changes:

  • Switches fetch_data() to return pandas.DataFrame instead of pyarrow.Table.
  • Adds optional first_n_rows parameter and implements batch-wise streaming conversion to pandas.
  • Introduces helper _stream_to_pandas() for record-batch stream → DataFrame conversion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/client.py
Comment thread dataconnect/client.py Outdated
Comment thread dataconnect/client.py
Comment thread dataconnect/client.py
Comment thread dataconnect/client.py

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/client.py
Comment thread dataconnect/client.py
Comment thread README.md
@ibaig-mdsol
ibaig-mdsol deleted the feat/MCC-1476014-2 branch June 8, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants