[MCC-1501368] Python Lib - Use Error Handler, Document and Update Messages for Fetch Data ()#31
Merged
Merged
Conversation
afieraru-mdsol
marked this pull request as draft
May 18, 2026 13:31
There was a problem hiding this comment.
Pull request overview
This PR refactors the fetch-data path to use a new DatasetTicket DTO and updates validation errors for fetch_data.
Changes:
- Adds
DatasetTicketto transport models. - Replaces
Transport.do_get(ResourceQuery)withTransport.get_ticket(DatasetTicket). - Updates
DefaultDataConnectService.fetch_datato build aDatasetTicketand raise structured validation errors.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
dataconnect/transport/models.py |
Adds the dataset fetch ticket DTO. |
dataconnect/transport/base.py |
Updates the transport interface for ticket-based fetches. |
dataconnect/transport/arrow_flight/transport.py |
Serializes DatasetTicket into an Arrow Flight ticket and calls do_get. |
dataconnect/service/default.py |
Updates fetch_data validation and dispatches through get_ticket. |
Comments suppressed due to low confidence (1)
dataconnect/service/default.py:109
- Several of these lines contain trailing whitespace after the comma before the newline, which violates the repository's configured Ruff
Wrules and will fail linting.
timestamp=datetime.now(UTC).strftime("%Y-%m-%dT%H:%M:%SZ"),
details=[ErrorDetail(field="first_n_rows",
message=f"Received {first_n_rows} for first_n_rows, which is not a positive integer.",
expected="Set first_n_rows to 1 or greater, or omit the parameter to retrieve the full dataset")],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
afieraru-mdsol
marked this pull request as ready for review
May 19, 2026 07:44
butsyk-mdsol
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature
Replace this line with Project title.MCC-1501368Pull request overview
This PR refactors the fetch-data path to use a new DatasetTicket DTO and updates validation errors for fetch_data.
Changes: