Skip to content

[MCC-1493223] Python SDK-Update Get Studies Function#33

Merged
butsyk-mdsol merged 3 commits into
mainfrom
feat/MCC-1493223
May 21, 2026
Merged

[MCC-1493223] Python SDK-Update Get Studies Function#33
butsyk-mdsol merged 3 commits into
mainfrom
feat/MCC-1493223

Conversation

@afieraru-mdsol

@afieraru-mdsol afieraru-mdsol commented May 20, 2026

Copy link
Copy Markdown
Contributor

feature/bug/enhance/refactor/tech_debt/hotfix

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

This PR updates the Python SDK’s get_studies API to return both the list of studies and the server-reported total count, aligning it more closely with other list-style responses.

Changes:

  • Introduces a new StudiesResult model (total + studies) and updates get_studies to return it.
  • Updates the public client/service interfaces to reflect the new return type.
  • Updates README usage example and adjusts (commented) tests to the new contract.
Screenshot 2026-05-20 at 15 31 16

Copilot AI review requested due to automatic review settings May 20, 2026 11:55
@afieraru-mdsol
afieraru-mdsol marked this pull request as draft May 20, 2026 11:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python SDK’s get_studies API to return both the list of studies and the server-reported total count, aligning it more closely with other list-style responses.

Changes:

  • Introduces a new StudiesResult model (total + studies) and updates get_studies to return it.
  • Updates the public client/service interfaces to reflect the new return type.
  • Updates README usage example and adjusts (commented) tests to the new contract.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
dataconnect/models.py Adds StudiesResult dataclass to represent get_studies results with total count.
dataconnect/service/default.py Changes get_studies implementation to return StudiesResult and compute total.
dataconnect/service/base.py Updates abstract service interface return type for get_studies.
dataconnect/client.py Updates public client get_studies return type.
README.md Updates quick-start example to use result.total and result.studies.
tests/test_service_default.py Updates expected behavior for get_studies (but tests remain commented out).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_service_default.py
Comment thread dataconnect/models.py
Comment thread dataconnect/service/default.py
Comment thread dataconnect/service/default.py
Comment thread dataconnect/service/default.py
Comment thread dataconnect/service/default.py
@butsyk-mdsol
butsyk-mdsol merged commit 3405f90 into main May 21, 2026
3 checks passed
@butsyk-mdsol
butsyk-mdsol deleted the feat/MCC-1493223 branch May 21, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants