[MCC-1493223] Python SDK-Update Get Studies Function#33
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Python SDK’s get_studies API to return both the list of studies and the server-reported total count, aligning it more closely with other list-style responses.
Changes:
- Introduces a new
StudiesResultmodel (total+studies) and updatesget_studiesto return it. - Updates the public client/service interfaces to reflect the new return type.
- Updates README usage example and adjusts (commented) tests to the new contract.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
dataconnect/models.py |
Adds StudiesResult dataclass to represent get_studies results with total count. |
dataconnect/service/default.py |
Changes get_studies implementation to return StudiesResult and compute total. |
dataconnect/service/base.py |
Updates abstract service interface return type for get_studies. |
dataconnect/client.py |
Updates public client get_studies return type. |
README.md |
Updates quick-start example to use result.total and result.studies. |
tests/test_service_default.py |
Updates expected behavior for get_studies (but tests remain commented out). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
afieraru-mdsol
marked this pull request as ready for review
May 20, 2026 12:27
butsyk-mdsol
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/bug/enhance/refactor/tech_debt/hotfix
Replace this line with Project title.MCC-1493223Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
This PR updates the Python SDK’s get_studies API to return both the list of studies and the server-reported total count, aligning it more closely with other list-style responses.
Changes: