[MCC-1501368] Python Lib - remove client validation for Fetch Data ()#35
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes client-side input validation from DefaultDataConnectService.fetch_data(), shifting responsibility for validation to the transport/server layer and updating the unit tests accordingly.
Changes:
- Removed UUID and
first_n_rowsvalidation logic fromDefaultDataConnectService.fetch_data(). - Deleted unit tests that asserted client-side
ValidationErrorbehavior forfetch_data().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dataconnect/service/default.py |
Removes pre-flight validators and ErrorDetail usage from fetch_data(). |
tests/test_fetch_data.py |
Removes fetch_data() client-validation test cases and the ValidationError import. |
Comments suppressed due to low confidence (1)
dataconnect/service/default.py:93
- With client-side validation removed, there’s no longer a unit test that locks in the new behavior (e.g., that
first_n_rows=0/negative values are passed through intoDatasetTicket.limitrather than raising aValidationError). Adding a focused test for this behavior will help prevent validation from being unintentionally reintroduced later.
def fetch_data(self, dataset_uuid: UUID, first_n_rows: int | None = None) -> pd.DataFrame:
"""Fetch data for a dataset"""
ticket = DatasetTicket(
dataset_uuid=str(dataset_uuid),
limit=first_n_rows,
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
butsyk-mdsol
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/bug/enhance/refactor/tech_debt/hotfix
Replace this line with Project title.MCC-1501368Changes Summary
This PR removes client-side input validation from DefaultDataConnectService.fetch_data(), shifting responsibility for validation to the transport/server layer and updating the unit tests accordingly.
Changes: