[MCC-1493223] Python SDK-Update Get Studies Function#37
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Python SDK’s “list studies” behavior by moving get_studies filter handling fully to the server (always sending the filter field, including null) and aligns the studies list response model naming by renaming StudiesResult.total to StudiesResult.total_records.
Changes:
- Always include
search_study_namein theget_studiesrequest body (encoded as JSON,nullwhen unset). - Rename
StudiesResult.totaltoStudiesResult.total_recordsand update service usage accordingly. - Update (commented-out) test expectations and naming to match the new request/response shape.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
dataconnect/service/default.py |
Changes get_studies to always append search_study_name into the request body and returns StudiesResult(total_records=...). |
dataconnect/models.py |
Renames StudiesResult.total field to total_records. |
tests/test_service_default.py |
Updates commented-out tests to expect null in request body and total_records naming. |
tests/test_client.py |
Updates commented-out client tests/stubs to use total_records. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
butsyk-mdsol
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/bug/enhance/refactor/tech_debt/hotfix
Replace this line with Project title.MCC-1493223Changes Summary
This PR updates the Python SDK’s “list studies” behavior by moving get_studies filter handling fully to the server (always sending the filter field, including null) and aligns the studies list response model naming by renaming StudiesResult.total to StudiesResult.total_records.
Changes: