Skip to content

[MCC-1493223] Python SDK-Update Get Studies Function#37

Merged
butsyk-mdsol merged 1 commit into
mainfrom
feat/MCC-1493223-2
May 22, 2026
Merged

[MCC-1493223] Python SDK-Update Get Studies Function#37
butsyk-mdsol merged 1 commit into
mainfrom
feat/MCC-1493223-2

Conversation

@afieraru-mdsol

@afieraru-mdsol afieraru-mdsol commented May 22, 2026

Copy link
Copy Markdown
Contributor

feature/bug/enhance/refactor/tech_debt/hotfix

Changes Summary

This PR updates the Python SDK’s “list studies” behavior by moving get_studies filter handling fully to the server (always sending the filter field, including null) and aligns the studies list response model naming by renaming StudiesResult.total to StudiesResult.total_records.

Changes:

  • Always include search_study_name in the get_studies request body (encoded as JSON, null when unset).
  • Rename StudiesResult.total to StudiesResult.total_records and update service usage accordingly.
  • Update (commented-out) test expectations and naming to match the new request/response shape.

Copilot AI review requested due to automatic review settings May 22, 2026 10:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python SDK’s “list studies” behavior by moving get_studies filter handling fully to the server (always sending the filter field, including null) and aligns the studies list response model naming by renaming StudiesResult.total to StudiesResult.total_records.

Changes:

  • Always include search_study_name in the get_studies request body (encoded as JSON, null when unset).
  • Rename StudiesResult.total to StudiesResult.total_records and update service usage accordingly.
  • Update (commented-out) test expectations and naming to match the new request/response shape.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
dataconnect/service/default.py Changes get_studies to always append search_study_name into the request body and returns StudiesResult(total_records=...).
dataconnect/models.py Renames StudiesResult.total field to total_records.
tests/test_service_default.py Updates commented-out tests to expect null in request body and total_records naming.
tests/test_client.py Updates commented-out client tests/stubs to use total_records.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/models.py
Comment thread dataconnect/service/default.py
@butsyk-mdsol
butsyk-mdsol merged commit 46e787b into main May 22, 2026
7 checks passed
@butsyk-mdsol
butsyk-mdsol deleted the feat/MCC-1493223-2 branch May 22, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants