[MCC-1476022] - Add Dry Publish Function#38
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “dry publish” (validation-only publish) flow to the DataConnect Python SDK, spanning transport → service → client layers, and introduces a domain result model plus unit tests to validate request/response mapping.
Changes:
- Introduced new DTOs/models for dry publish (
PublishRequest,DryPublishResponse,DryPublishResult) and exported them appropriately. - Added
dry_publish()to the service interface, default service implementation, and client façade; added mapperdry_publish_response_to_domain. - Implemented Arrow Flight transport
dry_publish_dataset()usingdo_put, schema normalization, and two-phase metadata parsing; added comprehensive unit tests.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_dry_publish.py | New unit tests covering type normalization, mapping, service request building/error translation, and transport behavior. |
| dataconnect/transport/models.py | Adds transport-layer DTOs for dry publish request/response. |
| dataconnect/transport/base.py | Extends the transport ABC with dry_publish_dataset(). |
| dataconnect/transport/arrow_flight/transport.py | Implements dry_publish_dataset() plus Arrow type normalization helper. |
| dataconnect/transport/init.py | Exposes newly added transport DTOs in the public transport package API. |
| dataconnect/service/mappers.py | Adds mapping from DryPublishResponse to domain DryPublishResult. |
| dataconnect/service/default.py | Adds DefaultDataConnectService.dry_publish() building config JSON and delegating to transport. |
| dataconnect/service/base.py | Extends the service interface with dry_publish(). |
| dataconnect/models.py | Introduces domain model DryPublishResult. |
| dataconnect/client.py | Adds DataConnectClient.dry_publish() delegating to the service. |
| dataconnect/init.py | Exports DryPublishResult at package top-level. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ibaig-mdsol
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MCC-1476022] - Add Dry Publish Function
Changes