Skip to content

[MCC-1476025] - Add Publish Function#39

Merged
ibaig-mdsol merged 2 commits into
mainfrom
features/MCC-1476025_1
May 23, 2026
Merged

[MCC-1476025] - Add Publish Function#39
ibaig-mdsol merged 2 commits into
mainfrom
features/MCC-1476025_1

Conversation

@slingampalli-mdsol

@slingampalli-mdsol slingampalli-mdsol commented May 23, 2026

Copy link
Copy Markdown
Contributor

[MCC-1476025] - Add Publish Function

Changes

  • Added publish feature
    • Introduces publish() on DataConnectClient / DataConnectService / DefaultDataConnectService, and publish_dataset() on the Transport interface.
    • Implements Arrow Flight transport support for publish, including schema normalization and two-phase metadata parsing (JSON + optional IPC invalid-records table).
    • Adds PublishResponse (transport) and PublishResult (domain) models and mapping via publish_response_to_domain, with new unit tests.

Copilot AI review requested due to automatic review settings May 23, 2026 03:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “live publish” capability to the DataConnect Python SDK, wiring a publish operation end-to-end (client → service → transport) and introducing corresponding transport/domain response models plus comprehensive unit tests.

Changes:

  • Introduces publish() on DataConnectClient / DataConnectService / DefaultDataConnectService, and publish_dataset() on the Transport interface.
  • Implements Arrow Flight transport support for publish, including schema normalization and two-phase metadata parsing (JSON + optional IPC invalid-records table).
  • Adds PublishResponse (transport) and PublishResult (domain) models and mapping via publish_response_to_domain, with new unit tests.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/test_publish.py New test suite covering publish mapper/service/transport/client delegation.
tests/test_dry_publish.py Updates dry-publish tests to satisfy the expanded Transport ABC (adds publish_dataset).
dataconnect/transport/models.py Adds PublishResponse DTO and expands docs around publish request/response models.
dataconnect/transport/base.py Extends the Transport ABC with publish_dataset().
dataconnect/transport/arrow_flight/transport.py Implements publish_dataset() using Arrow Flight do_put and parses publish metadata.
dataconnect/transport/init.py Re-exports PublishResponse.
dataconnect/service/mappers.py Adds publish_response_to_domain() mapper.
dataconnect/service/default.py Implements DefaultDataConnectService.publish() building PublishRequest and translating errors.
dataconnect/service/base.py Extends DataConnectService interface with publish().
dataconnect/models.py Adds PublishResult domain model.
dataconnect/client.py Adds DataConnectClient.publish() plus expanded docstrings.
dataconnect/init.py Exports PublishResult from the package root.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/service/mappers.py Outdated
Comment thread dataconnect/client.py Outdated
Comment thread dataconnect/client.py
Comment thread dataconnect/transport/models.py Outdated
@ibaig-mdsol
ibaig-mdsol merged commit 6f65e35 into main May 23, 2026
3 checks passed
@ibaig-mdsol
ibaig-mdsol deleted the features/MCC-1476025_1 branch May 23, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants