Skip to content

[MCC-1476014] Python Lib-Create Fetch_data() function#7

Closed
afieraru-mdsol wants to merge 4 commits into
mainfrom
feat/MCC-1476014-create-fetch_data
Closed

[MCC-1476014] Python Lib-Create Fetch_data() function#7
afieraru-mdsol wants to merge 4 commits into
mainfrom
feat/MCC-1476014-create-fetch_data

Conversation

@afieraru-mdsol

@afieraru-mdsol afieraru-mdsol commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

feature/bug/enhance/refactor/tech_debt/hotfix

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

  • Create fetch_data() function

Copilot AI review requested due to automatic review settings April 30, 2026 14:34
@afieraru-mdsol
afieraru-mdsol marked this pull request as draft April 30, 2026 14:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new fetch_data() implementation to the Python DataConnect client, aiming to fetch dataset data via Arrow Flight and return it in a more user-friendly format.

Changes:

  • Added pandas as a Poetry dependency.
  • Updated fetch_data() to return a pandas.DataFrame and added a _get_dataset() helper to stream record batches.
  • Consolidated exception imports in the PyArrow transport module.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
pyproject.toml Adds pandas to core dependencies to support returning DataFrames from the client.
dataconnect/framework/pyarrow_transport.py Adjusts exception imports for the Flight transport implementation.
dataconnect/client.py Reworks fetch_data() to produce a DataFrame and introduces _get_dataset() to stream/assemble results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/client.py
Comment thread pyproject.toml Outdated
Comment thread dataconnect/framework/pyarrow_transport.py Outdated
Comment thread dataconnect/client.py
Comment thread dataconnect/client.py Outdated
@afieraru-mdsol
afieraru-mdsol force-pushed the feat/MCC-1476014-create-fetch_data branch from ec83ed8 to d4a3a56 Compare May 4, 2026 11:57
@ibaig-mdsol
ibaig-mdsol deleted the feat/MCC-1476014-create-fetch_data branch June 8, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants