[MCC-1496700] Python Lib-Create Get_datasets() function#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new paginated dataset-listing flow to the Python DataConnect client by switching from an action-based request to Arrow Flight list_flights, and introduces shared pagination/response models to surface server pagination metadata to callers.
Changes:
- Implement
DataConnectClient.datasets()as a paginated Flight listing that returnsPaginatedResponse[Dataset]withPaginationmetadata. - Add
FlightResult+FlightTransport.list_flights()abstraction and implement it inPyArrowFlightTransport. - Add/expand unit tests covering datasets pagination/criteria and TLS vs TCP connection schemes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_client.py | Adds unit/integration-style tests for datasets() pagination behavior and connect() TLS/TCP scheme handling. |
| dataconnect/models.py | Introduces Pagination / PaginatedResponse and updates dataset/environment models toward UUID-based fields. |
| dataconnect/framework/transport.py | Adds FlightResult and FlightTransport.list_flights() contract for listing operations. |
| dataconnect/framework/pyarrow_transport.py | Implements list_flights() to extract ticket data + app metadata from FlightInfo. |
| dataconnect/client.py | Refactors datasets() to use list_flights() and return paginated responses; updates connection scheme selection. |
| dataconnect/init.py | Exposes Pagination and PaginatedResponse from the package public API. |
| README.md | Updates installation notes and Python version requirement text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slingampalli-mdsol
marked this pull request as draft
May 1, 2026 11:26
butsyk-mdsol
force-pushed
the
features/MCC-1496700
branch
from
May 11, 2026 13:59
37f54fd to
2ced0a4
Compare
butsyk-mdsol
marked this pull request as ready for review
May 11, 2026 13:59
butsyk-mdsol
force-pushed
the
features/MCC-1496700
branch
from
May 11, 2026 14:02
2ced0a4 to
db0b826
Compare
butsyk-mdsol
force-pushed
the
features/MCC-1496700
branch
3 times, most recently
from
May 11, 2026 14:22
863363a to
ffd75e7
Compare
ibaig-mdsol
reviewed
May 11, 2026
butsyk-mdsol
force-pushed
the
features/MCC-1496700
branch
2 times, most recently
from
May 11, 2026 14:35
e0bb977 to
4868e7e
Compare
ibaig-mdsol
reviewed
May 11, 2026
ibaig-mdsol
reviewed
May 11, 2026
ibaig-mdsol
reviewed
May 11, 2026
butsyk-mdsol
force-pushed
the
features/MCC-1496700
branch
from
May 12, 2026 07:52
4868e7e to
4691371
Compare
butsyk-mdsol
force-pushed
the
features/MCC-1496700
branch
from
May 12, 2026 07:57
4691371 to
07f2c9e
Compare
dsilaghi-mdsol
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature
Python Lib-Create Get_datasets() function.MCC-1496700Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
Expectation: retrieve a list of datasets filtered by either a broad Study or a specific Study Environment.
Requirements:
Function: get_datasets().
Key Requirements: * Accept study_uuid as a mandatory identifier.
Support fuzzy searching via search_dataset_name. Returns list of Dataset objects in the given study environment and the dataset name (if provided).
Technical Note: Output must return Dataset objects containing unique UUIDs required for downstream functions.
Pagination Transparency: Unlike a "silent" requester, this function provides full visibility into result set boundaries—users always know if they're seeing 10% or 100% of available data through embedded metadata.
Context Resolution: Since dataset_uuid values are unique only within the scope of a study environment, the underlying Arrow Flight Server dynamically resolves full context (study_uuid, study_environment_uuid) via OneApi integration to properly authorize and route requests.