fix: bundle html-to-image, hide full-page capture on complex DOMs#106
Merged
fix: bundle html-to-image, hide full-page capture on complex DOMs#106
Conversation
Three-part fix for screenshot failures on complex pages (11k+ nodes): 1. Bundle html-to-image via esbuild instead of CDN loading — eliminates Tracking Prevention blocking on Edge/Firefox/Brave. Widget size goes from ~50KB to ~67KB. 2. Hide Full Page and Select Area buttons when DOM exceeds 10k nodes — area capture does a full-page render then crops, so it hits the same freeze. Only Select Element remains available. Adds domNodeCount and fullPageDisabled to issue metadata for diagnostics. 3. Rework E2E mocking from CDN route interception to addInitScript with a window.__bugdropMockToPng test seam. Adds threshold visibility tests, metadata payload tests, and one unmocked smoke test that exercises the real bundled html-to-image. Also fixes: benchmark spec handles hidden button gracefully, CI paths-ignore removed to avoid blocking merge queue, CLAUDE.md updated.
|
🎉 This PR is included in version 1.27.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #101 — screenshot capture fails on complex DOM pages (11k+ nodes) due to main-thread blocking and CDN being blocked by Tracking Prevention.
domNodeCountandfullPageDisabledto issue metadata.page.route) topage.addInitScriptwith awindow.__bugdropMockToPngtest seam.full_page_disabledoutcome).paths-ignorethat would block merge queue on benchmark-only PRs.Test plan
getDomNodeCount,isFullPageDisabledboundary x2)