fix: pass release tag as VERSION to deploy builds#107
Merged
Conversation
The deploy jobs were building widget.js with the stale package.json version (1.14.0) because semantic-release doesn't bump package.json (no @semantic-release/npm plugin — branch protection blocks pushes). Fix: fetch full git history (fetch-depth: 0) and pass the latest tag via VERSION=$(git describe --tags --abbrev=0) to the build script, which already checks process.env.VERSION before package.json.
|
🎉 This PR is included in version 1.27.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
neonwatty
added a commit
that referenced
this pull request
Apr 15, 2026
Closes #109 Every merged PR previously ran the full test suite three times — PR, merge_group, and a post-merge push: main rerun of the exact same SHA the queue had just validated. The push rerun wasted ~25 runner-minutes per merge and proved nothing the merge queue hadn't already proven. Move the release (semantic-release) and deploy (Cloudflare Workers) jobs into a new deploy.yml triggered on push: branches: [main]. Drop push: [main, develop] from ci.yml entirely — develop doesn't exist in this repo, and ci.yml now runs only on pull_request and merge_group. The release → deploy chain stays in a single workflow via needs: [release], so the tag semantic-release creates is visible to git describe --tags in the deploy job's VERSION build arg (preserving the fix from #107).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonversion (1.14.0) because semantic-release doesn't bumppackage.json(no@semantic-release/npmplugin — branch protection blocks direct pushes).v1.14.0in the modal footer, regardless of the actual release version.fetch-depth: 0+VERSION=$(git describe --tags --abbrev=0)passes the latest git tag to the build script, which already checksprocess.env.VERSIONbeforepackage.json.deploy-previewanddeployjobs.Test plan
.github/workflows/ci.ymlchanged)https://bugdrop.neonwatty.workers.dev/widget.v1.jscontains the new version number