Skip to content

test(codex-operations): normalize collector stdout newlines on Windows #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Sep 8, 2026
Merged

test(codex-operations): normalize collector stdout newlines on Windows #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/codex-operations.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,23 @@ function findPython() {
const python = findPython();
const skip = python ? false : "Python 3 is not available";

const toLf = (text) => (typeof text === "string" ? text.replaceAll("\r\n", "\n") : text);

function runCollector(args, env) {
if (!python) {
throw new Error("runCollector needs Python; give this test the shared { skip } guard");
}
return spawnSync(python.command, [...python.prefix, collector, ...args], {
const result = spawnSync(python.command, [...python.prefix, collector, ...args], {
encoding: "utf8",
env,
});
// Python's text-mode stdout writes the platform newline, so on Windows every
// line the collector prints arrives as `\r\n`. That is correct for the tool
// and invisible to a `.includes()` assertion, but a test that splits on `\n`
// and compares a whole line for equality reads the trailing `\r` as a content
// difference. Normalize once here so every assertion below sees the same text
// on every platform; the collector itself is unchanged.
return { ...result, stdout: toLf(result.stdout), stderr: toLf(result.stderr) };
}

async function makeTempDir(t, prefix) {
Expand Down