Fix missing stack aligns#253
Merged
kkysen merged 5 commits intokkysen/update-to-latest-nightlyfrom May 23, 2023
Merged
Conversation
randomPoison
approved these changes
May 23, 2023
kkysen
force-pushed
the
kkysen/update-to-latest-nightly
branch
from
df2158b to
7593d2e
Compare
…d arch. `Align1` is used when alignment wasn't specified in C to avoid have to `cfg` the uses of `scaling`.
kkysen
force-pushed
the
kkysen/fix-missing-stack-aligns
branch
from
e4dffdf to
c2cbe1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251 and
should hopefully fixfixes #250,. If it fixes #250,so I can merge this PR into #249, and then when #249 passes CI, I can merge that intomain(or I can rebase this onmainand reverse the PR order, now that I know this and #249 fixes #250).