docs(skill): document a data grid's column filters where a data grid is documented - #1167
Merged
Merged
Conversation
The filter widgets section of the create-page widget reference opened with "Filter widgets are used inside GALLERY FILTER containers", so a reader building a data grid stopped at the first line -- everything under it, including the association form, applies to a grid column just as well. The lead-in now names both homes, the grid column first, with a two-line example of each.
The type table in overview-pages maps each attribute type to its filter widget and stops there, so the two forms a real list reaches for first were nowhere on the page a reader building that list opens: a dropdownfilter over an association (Association + datasource + CaptionAttribute), and FilterType: between for a date range. Both verified on a blank 11.12.1 project -- check, exec, mx check 0 errors, and DESCRIBE returning the same line. The section also says now that the grid filters itself, because the alternative keeps being written: a non-persistent filter entity, inputs bound to it, an apply microflow on every change and an XPath reading that object back -- three microflows and 1,100 characters of XPath on one generated app, against five lines. 675 -> 696 lines, under the 700 the split test allows.
AI Code ReviewCritical Issues
Moderate Issues
Minor Issues
What Looks Good
Recommendation
Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1166
What
Documentation only. A DataGrid2 filters itself and mxcli supports every part of it; the pages that say so are not the pages a reader building a grid opens.
create-page/reference/widgets.mdopened its filter section with "Filter widgets are used inside GALLERY FILTER containers". Everything under that line —textfilter,numberfilter,datefilter,dropdownfilterand the association form — applies to a data grid column too, but the section announced itself as being about galleries. The lead-in now names both homes, the grid column first, with a two-line example of each.overview-pages/SKILL.mdhad a table mapping each attribute type to its filter widget and nothing else. It gains the two forms a real list needs first: adropdownfilterover an association (Association:+datasource:+CaptionAttribute:), andFilterType: betweenfor a date range. Plus one short paragraph saying the grid filters itself, because the alternative keeps being written.Why the last paragraph
Two apps generated with mxcli, by different models, independently built the same filter bar on their order list: a non-persistent filter entity, inputs bound to its attributes, an apply microflow on every
OnChange, a Clear button, and an XPath on the grid reading the filter object back. One of them cost three microflows (66 lines of MDL), nine input widgets and 1,100 characters of XPath where five column filters do the same job — and the hand-built version loses the paging, sorting and per-user personalisation the grid does on its own.Verified
Blank 11.12.1 project, binary built from
mainat 643271e:mxcli check --referencespasses,execapplies it,mx checkreports 0 errors, andDESCRIBE PAGEreturns the same line. The association form round-trips the same way.overview-pages/SKILL.mdgoes 675 → 696 lines, under the 700TestLargeSkillsWereSplitallows.Validation
Full local run of
push-test.yml, green:make build,make test,check-tunnel-deps,make check-mdl,make check-skill-pack-js,make check-findings,make check-wiki-pages,check-skill-mdl.shover.claude/skills/mendixanddocs-site/src,make lint-go,make test-integrationagainstmx11.12.1.