imei attribute from /organizations/{organizationId}/devices response does not match API#58
Open
ben-pearce wants to merge 1 commit intomeraki:masterfrom
Open
imei attribute from /organizations/{organizationId}/devices response does not match API#58ben-pearce wants to merge 1 commit intomeraki:masterfrom
imei attribute from /organizations/{organizationId}/devices response does not match API#58ben-pearce wants to merge 1 commit intomeraki:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the correct place to raise this.
The IMEI attribute from the list of devices returned by
/organizations/{organizationId}/devicesdoes not match real response from the Meraki API.The schema suggests that
imeiis to be astringbut in reality the response value is anumber.To me it makes more sense if
imeiis a string but this PR just alters the spec to match what is true in reality. I think ideally the API would instead return the correct type.