Open
Conversation
meshtag
requested changes
Nov 5, 2022
Owner
meshtag
left a comment
meshtag
left a comment
There was a problem hiding this comment.
Please add a clear description for your PR. You can summarize your thinking and express any design changes proposed by you.
meshtag
requested changes
Nov 13, 2022
Owner
|
Ping @RISHI27-dot |
1. Removed the print statements in tests. 2. Use different approach for testing the move assignment operator and the move constructor. 3. Steal the members of the original object using std::swap() as the constructor MemRef<float, 2>::MemRef cannot be called directly. 4. Remove unwanted variable in CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tests the translation of graphs into MemRef using a variety of different graph representations. Additionally, this PR includes tests for the overloaded operators and constructors of the MemRef Class.
An object of the Graph class is created and edges are added to the graph. The graph is then converted to MemRef. Now, a MemRef class object is created with the allocated, strided, size, and sizes fields hardcoded, giving us a resulting MemRef object that should exactly match the MemRef obtained after the conversion from the graph. Comparison of the two MemRef class objects is handled by the overloaded comparison operator.