Node list molecule #3909
Draft
Node list molecule #3909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
jamesarich
reviewed
Dec 8, 2025
Collaborator
There was a problem hiding this comment.
Boy this does clean up the viewmodel quite a bit, though I'm a bit nervous to take on a dependency that ties us into a specific architecture/pattern. I've been bitten by this in the past.. anyone remember https://github.com/airbnb/epoxy 😬 ?
I'd have to better understand what relying on this would mean for the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is a couple weeks old, so rebasing had a bunch on conflicts which haven't been addressed yet. Figured I'd throw a draft up here before fixing for some visibility and to see if other folks like this pattern.
This PR introduces Molecule to
NodeListViewModelto clean up its Flow combination logic. This circumvents the arg count limitations ofFlow.combine()while maintaining type safety when combining many Flows. Instead of using theFlow.combine()operator, Molecule allows us to collect the needed flows in a VM-level Composable, then construct the desired emission which is still exposed to the UI as a Flow.