-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat: add retention period to meshLog. Defaults to 7 days, with a settings dropdown to change #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ttings dropdown to change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4078 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 19 19
Branches 7 7
=====================================
Misses 19 19 ☔ View full report in Codecov by Sentry. |
jamesarich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of things to clean up
Features added: mesh log retention, ability to turn off mesh log all together, ability to export more than the last 500 packets
Default: 7 days retention. I started at 30 but there are performance/size implications for larger meshes. I'd honestly like lower default retention (3days). End users shouldn't miss it as all because old default didn't allow for exporting the entire log anyways.
Settings added in debug panel > new settings cog. Added in here to decrease complexity of main settings screen for items that will rarely be touched.