Skip to content

fix(ci): sync Flatpak Gradle distribution - #6625

Merged
jamesarich merged 1 commit into
meshtastic:mainfrom
simulationstation:fix/flatpak-gradle-distribution
Aug 12, 2026
Merged

fix(ci): sync Flatpak Gradle distribution#6625
jamesarich merged 1 commit into
meshtastic:mainfrom
simulationstation:fix/flatpak-gradle-distribution

Conversation

@simulationstation

Copy link
Copy Markdown
Contributor

Summary

Keep the offline Flatpak manifest's bundled Gradle distribution in sync with the checked-in wrapper:

  • use gradle-9.6.1-bin.zip
  • use the wrapper's 9c0f…e14 SHA-256

Root cause

#6611 pinned the repository wrapper back from Gradle 9.7.0 to 9.6.1, but scripts/verify-flatpak/desktop-offline.yaml still downloaded the 9.7.0 binary.

The Flatpak build rewrites distributionUrl to that bundled ZIP while retaining distributionSha256Sum from gradle-wrapper.properties. Both architectures therefore fail before project compilation:

Expected checksum: 9c0f7fae...32c9e14
Actual checksum:   84fbba45...d873ae

This surfaced in the Flatpak checks on #6624 and is independent of that PR's messaging changes.

Validation

  • parsed the wrapper properties and Flatpak manifest and asserted exact URL/SHA equality
  • git diff --check
  • the existing x86_64 and aarch64 Flatpak workflow provides the end-to-end offline build check

@simulationstation
simulationstation marked this pull request as ready for review August 11, 2026 22:34
@github-actions github-actions Bot added the bugfix PR tag label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@simulationstation, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a10c3789-beba-4904-9ae7-ab6bcce45789

📥 Commits

Reviewing files that changed from the base of the PR and between a22bf5e and f5d307b.

📒 Files selected for processing (1)
  • scripts/verify-flatpak/desktop-offline.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamesarich
jamesarich added this pull request to the merge queue Aug 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 12, 2026
@jamesarich
jamesarich added this pull request to the merge queue Aug 12, 2026
Merged via the queue into meshtastic:main with commit 0c98de8 Aug 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants