test(settings): fix flaky installProfile snackbar test

[jamesarich]

Why

installProfile surfaces malformed channel URL in snackbar in RadioConfigViewModelTest is flaky — it failed 2 of 3 attempts in a local allTests run with Mokkery's "Expected showSnackbar() call but received none", passing on retry.

The root cause is not the ViewModel's dispatcher wiring: installProfile's catch block calls UiText.Resource(Res.string.channel_invalid).resolve(), which goes through CMP getString(). Since CMP 1.12 the resource async cache loads on real Dispatchers.Default — outside the runTest scheduler. The coroutine suspends there, so runCurrent() (and even advanceUntilIdle()) returns with nothing to drain, and the verify races the real Default thread. Passing runs were just the real thread winning.

🧹 Changes

• Stub snackbarManager.showSnackbar to complete a CompletableDeferred, and replace runCurrent() with awaiting that deferred, so the test deterministically waits for the effect. The exact-message assertion is unchanged.
• Deliberately no inner withTimeout — inside runTest it runs on virtual time and would fire spuriously while waiting on the real dispatcher; a genuine hang is still caught by runTest's 60s real-time timeout.

Note for future tests in this file: any assertion downstream of UiText.resolve() has the same trap; reuse this await-the-effect pattern instead of runCurrent()/advanceUntilIdle().

Testing Performed

• :feature:settings:allTests run 3× (twice with --rerun-tasks to defeat caching; 205 tests executed each run, verified no FROM-CACHE) — target test passed all runs.
• :feature:settings:detekt spotlessCheck — clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Improved reliability of malformed-profile URL validation tests by properly waiting for asynchronous snackbar notifications.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 49ee41ee-0ebf-4050-a239-338545993c28

📥 Commits

Reviewing files that changed from the base of the PR and between 2f38736 and dd3aa3a.

📒 Files selected for processing (1)

• feature/settings/src/commonTest/kotlin/org/meshtastic/feature/settings/radio/RadioConfigViewModelTest.kt

---

📝 Walkthrough

Walkthrough

The malformed channel URL test now uses CompletableDeferred to await asynchronous snackbar delivery instead of calling runCurrent().

Changes

Settings test synchronization

Layer / File(s)	Summary
Await malformed URL snackbar feature/settings/src/commonTest/kotlin/org/meshtastic/feature/settings/radio/RadioConfigViewModelTest.kt	The test completes a deferred when the snackbar appears and awaits it after installProfile. The file imports CompletableDeferred.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Mergeability Score: ⚪ Minimal · up to dd3aa

This change makes the flaky snackbar test wait deterministically for the expected effect without changing production behavior; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• meshtastic/Meshtastic-Android#6669: Updates the same malformed-profile test with ViewModel and coroutine-scope lifecycle changes.

Suggested reviewers: jeremiah-k, simulationstation

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Tests Prove The Path, Not The End State	❓ Inconclusive	Investigation is still in progress; no verdict submitted yet.	Inspect the changed test and its production path before deciding.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the flaky snackbar test fix implemented in the pull request.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Sibling Call Sites And Presence Semantics	✅ Passed	The diff only changes snackbar-test synchronization and adds an import; it changes no field presence semantics, zero-guard, nullable value, or physical measurement default.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}