chore(build): bump flatpak-sources plugin to 0.1.7, drop Isolated Projects workaround - #6690
Conversation
…jects workaround 0.1.5 read Gradle.extensions in a way Isolated Projects forbids, so every flatpak-sources generation call had to disable IP + config cache and the plugin itself was gated behind an opt-in property in settings.gradle.kts. 0.1.7 fixes this upstream (shares state via a BuildService instead), so: - Apply the plugin unconditionally again, at its real version. - Drop -Dorg.gradle.isolated-projects=false --no-configuration-cache -Pmeshtastic.flatpakSources=true from the four call sites that carried it (verify-flatpak.yml, release.yml, reusable-check.yml, verify.sh). Verified end-to-end, not just compiled: ran the real :desktopApp:packageUberJarForCurrentOS :captureFlatpakSources pipeline with Isolated Projects left ON (this repo's default) and no workaround flags — 189 tasks, zero IP/config-cache violations, flatpak-sources.json emitted with 2808 captured URLs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe Flatpak sources settings plugin is upgraded and applied unconditionally. CI workflows and the verification script stop passing obsolete isolated-projects, configuration-cache, and Flatpak source properties. ChangesFlatpak source generation
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This change updates the Flatpak sources plugin and removes obsolete Gradle workarounds while preserving the verified build pipeline; no actionable merge-blocking risk remains. Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
org.meshtastic.flatpak.sources.settingswas pinned at 0.1.5 because it readGradle.extensionsin a way Isolated Projects forbids — this repo runs withIsolated Projects on by default (
org.gradle.isolated-projects=true), soevery flatpak-sources generation call had to disable IP + config cache, and
the plugin itself was gated behind an opt-in property in
settings.gradle.kts. Upstream 0.1.7(meshtastic/gradle-flatpak-sources#36)
fixes the incompatibility by sharing state via a
BuildServiceinstead.Changes
org.meshtastic.flatpak.sources.settings0.1.5 → 0.1.7 and apply itunconditionally again (removed the
apply false+ opt-in-property gate).-Dorg.gradle.isolated-projects=false --no-configuration-cache -Pmeshtastic.flatpakSources=truefrom the four call sites that carriedit:
verify-flatpak.yml,release.yml,reusable-check.yml,verify.sh.Testing Performed
Verified end-to-end, not just compiled: ran the real
:desktopApp:packageUberJarForCurrentOS :captureFlatpakSourcespipelinewith Isolated Projects left on (this repo's default) and none of the
removed workaround flags — 189 tasks, zero IP/config-cache violations,
flatpak-sources.jsonemitted with 2808 captured URLs.Summary by CodeRabbit