claw back some space from signing policies

[NomDeTom]

#10967 introduced some large flash objects due to the way it was initialised, plus some long and unoptimised logging strings.

• The policy member of RoutingAuthCache is no longer initialized in-class, which saves flash memory. Instead, it is set to its default value at runtime in the Router constructor. [1] [2]

• Several log messages in passesRoutingAuthGate have been shortened and clarified to remove redundant phrases and better indicate packet handling outcomes. [1] [2]

May conflict or be duplicated by #11144

🤝 Attestations

• I have tested that my proposed changes behave as described.
• I have tested that my proposed changes do not cause any obvious regressions on the following devices:
  • Heltec (Lora32) V3
  • LilyGo T-Deck
  • LilyGo T-Beam
  • RAK WisBlock 4631
  • Seeed Studio T-1000E tracker card
  • Other (please specify below)

Summary by CodeRabbit

• Bug Fixes
  • Preserved the default balanced routing policy during router initialization.
  • Clarified warning messages for routing signature-policy rejections and decoding failures.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a675e1d4-5e9b-4027-823b-df4ba5b6b97d

📥 Commits

Reviewing files that changed from the base of the PR and between f90c134 and 583248c.

📒 Files selected for processing (1)

• src/mesh/Router.cpp

---

📝 Walkthrough

Walkthrough

The router moves the routing authentication policy default from in-class initialization to constructor setup and revises warning messages for authentication rejection and decode failure paths without changing verdict behavior.

Changes

Routing authentication updates

Layer / File(s)	Summary
Runtime policy default src/mesh/Router.cpp	RoutingAuthCache::policy is left uninitialized in the struct and set to PACKET_SIGNATURE_POLICY_BALANCED in Router::Router.
Authentication gate log wording src/mesh/Router.cpp	Warning messages for policy rejection and decode failure branches are reworded; all affected branches still return RoutingAuthVerdict::REJECT.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: caveman99, jp-bennett, thebentern

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and matches the main change: reducing space usage in signing policy handling.
Description check	✅ Passed	The description covers the change summary and includes the required attestations section from the template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.