test: cover packet policy coercion on excluded builds - #11154
Conversation
db145bc to
3d4087a
Compare
📝 WalkthroughWalkthroughThe local security-config Unity test now validates ChangesPacket signature policy tests
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3d4087a to
8acb7fe
Compare
⚡ Try this PR in the Web FlasherWarning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (30)
Build artifacts expire on 2026-08-21. Updated for |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/test_admin_session_repro/test_main.cpp`:
- Line 680: Move the test_local_security_config_applies_packet_signature_policy
registration outside the `#if` !(MESHTASTIC_EXCLUDE_PKI) guard so it executes when
PKI is excluded, while preserving any fixture or setup requirements that must
remain PKI-specific.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4df2a139-ecbf-463f-88ef-50b0f3750beb
📒 Files selected for processing (1)
test/test_admin_session_repro/test_main.cpp
Summary
Validation
./bin/test-native-docker.sh -f test_admin_session_repro— 25 test cases succeededgit diff --checkFollow-up to #11134 to address its CodeRabbit review finding. No hardware verification performed; this is a native configuration-path test.
Summary by CodeRabbit