Skip to content

BaseUI: Clean up dead code - #11306

Merged
thebentern merged 2 commits into
developfrom
baseui_deadcodecleanup
Jul 31, 2026
Merged

BaseUI: Clean up dead code#11306
thebentern merged 2 commits into
developfrom
baseui_deadcodecleanup

Conversation

@Xaositek

@Xaositek Xaositek commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

BaseUI: Clean up dead code

Removes:

  • class DebugInfo
  • void drawFrame
  • void drawDebugInfoWiFiTrampoline
  • drawGpsPowerStatus
  • old S&F images that are unused

Summary by CodeRabbit

  • Refactor
    • Removed the legacy debug display and its unused status integrations.
    • Streamlined the interface by eliminating obsolete diagnostic and GPS power-status rendering components.
    • Cleaned up unused question, information, and Store-and-Forward icon assets.
    • Simplified display-related functionality while preserving remaining UI behavior, Wi-Fi rendering, and callback handling.
    • Retained existing Wi-Fi and other screen displays.

@Xaositek Xaositek self-assigned this Jul 31, 2026
@Xaositek Xaositek added baseui Issues directly related to BaseUI 2.8 cleanup Code cleanup or refactor labels Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The graphics cleanup removes legacy debug rendering, its declarations and dependencies, the GPS power-status renderer, and obsolete question, info, and Store-and-Forward image declarations. WiFi rendering now calls drawFrameWiFi directly.

Changes

Graphics cleanup

Layer / File(s) Summary
Remove legacy debug rendering
src/graphics/draw/DebugRenderer.cpp, src/graphics/draw/DebugRenderer.h, src/graphics/Screen.cpp
The legacy drawFrame renderer and WiFi trampoline are removed. Related dependencies and declarations are deleted. The WiFi frame callback now uses drawFrameWiFi.
Remove obsolete graphics assets and GPS API
src/graphics/draw/UIRenderer.h, src/graphics/images.h
The GPS power-status declaration and obsolete question, info, and Store-and-Forward bitmap declarations are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: caveman99, jp-bennett, harukitoreda

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the code removals but omits the required testing attestations and affected-device regression results. Add the Attestations section and state whether the changes were tested, including regression results for each affected device or explain unavailable hardware.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the removal of unused BaseUI code.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch baseui_deadcodecleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thebentern
thebentern added this pull request to the merge queue Jul 31, 2026
Merged via the queue into develop with commit 3d8ff48 Jul 31, 2026
58 checks passed
@Xaositek
Xaositek deleted the baseui_deadcodecleanup branch July 31, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.8 baseui Issues directly related to BaseUI cleanup Code cleanup or refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants