Skip to content

Feat/heltec v4 r2 - #11378

Draft
MuddyPaws2 wants to merge 16 commits into
meshtastic:developfrom
MuddyPaws2:feat/heltec-v4-r2
Draft

Feat/heltec v4 r2#11378
MuddyPaws2 wants to merge 16 commits into
meshtastic:developfrom
MuddyPaws2:feat/heltec-v4-r2

Conversation

@MuddyPaws2

Copy link
Copy Markdown

🙏 Thank you for sending in a pull request, here's some tips to get started!

❌ (Please delete all these tips and replace them with your text) ❌

  • Before starting on some new big chunk of code, it it is optional but highly recommended to open an issue first
    to say "Hey, I think this idea X should be implemented and I'm starting work on it. My general plan is Y, any feedback
    is appreciated." This will allow other devs to potentially save you time by not accidentally duplicating work etc...
  • Please do not check in files that don't have real changes
  • Please do not reformat lines that you didn't have to change the code on
  • We recommend using the Visual Studio Code editor along with the 'Trunk Check' extension (In beta for windows, WSL2 for the Linux version),
    because it automatically follows our indentation rules and its auto reformatting will not cause spurious changes to lines.
  • If your PR fixes a bug, mention "fixes #bugnum" somewhere in your pull request description.
  • If your other co-developers have comments on your PR please tweak as needed.
  • Please also enable "Allow edits by maintainers".
  • Please do not submit untested code.
  • If you do not have the affected hardware to test your code changes adequately against regressions, please indicate this, so that contributors and community members can help test your changes.
  • If your PR gets accepted you can request a "Contributor" role in the Meshtastic Discord

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

MuddyPaws2 and others added 16 commits July 24, 2026 19:02
…pping

- Extend esp32s3_base instead of heltec_v4_base to avoid heltec_v4/variant.h
  shadowing the R2 header and causing TFTDisplay.cpp to compile incorrectly
- LGFX_PIN_MISO=-1: GPIO26 is PSRAM CS on ESP32-S3, must not be used for SPI
- LGFX_ROTATION=2, VIEW_320x240, DISPLAY_SIZE=320x240: working display orientation
- Add HELTEC_V4_R2 to architecture.h hw model mapping (-> HELTEC_V4, model 110)
- Add HELTEC_V4_R2 to NodeDB BT default-off list for MUI boards

Note: lv_conf.h in meshtastic/device-ui also needs updating to guard
LV_MEM_POOL_ALLOC with CONFIG_SPIRAM_USE_MALLOC detection (see separate PR).
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a439718-c91a-4932-a5bb-ee0905990695

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants