Add needed support bits for the Meshstick #9042
Merged
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-bennett
added
hardware-support
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Meshstick device auto-detection and device ID extraction. The changes enable the system to detect Meshstick hardware via USB and extract a unique device ID from the CH341 USB chip's product string.
- Modified the product string retrieval to use
memcpyinstead ofstrncpy - Added logic to extract a 16-byte device ID from data following the null terminator in the CH341 product string
- Added YAML configuration file for the Meshstick-1262 hardware variant
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/platform/portduino/USBHal.h | Changed strncpy to memcpy in getProductString() method |
| src/platform/portduino/PortduinoGlue.cpp | Added device ID extraction logic for CH341-based devices by reading 16 bytes after the product string's null terminator |
| bin/config.d/lora-usb-meshstick-1262.yaml | New configuration file defining hardware parameters for Meshstick with SX1262 radio module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fifieldt
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get auto-detection working with the meshstick, as well as gives us a way to pull a DeviceID from those devices.