Conversation
acaa8d7 to
b07cd56
Compare
I did allow edit by maintainers, but since you are no maintainer of this repo, you can't push to the branch. I'll look into your PR into this branch- Thanks for helping out, It worked locally for me, but while trying to fix it for windows I added an error and then I didn't have enough time to fix it again. 😓 |
50aca04 to
90f4bec
Compare
|
any updates on this? |
We should ask potential reviewers (maintainers), as I use this wrap already privately, it works for me ™️ , but it also compiles everywhere, so it just needs to be reviewed 😓 |
bgilbert
left a comment
There was a problem hiding this comment.
There's already a glfw wrap the parent project can install if needed, so we shouldn't support the embedded GLFW at all. It adds a lot of complexity here and reimplements Meson code maintained elsewhere, and also using private copies of library code isn't great.
532cfdd to
8d26532
Compare
I agree and I removed it, but I left it in for commit #1, so that in the future, if this would be needed, it would be in the git history :) |
|
Any plans to merge this in the future, are any changes from me needed, or any notes on #2016 (comment) Just checking after some time 👀 |
… much build defintion, when the glfw3 wrap can be used too
This is by no means feature complete, I just converted the Makefile + cmake build files to this.
Feel free to suggest changes :)
Linux compilation tested, (Windows and MacOS will be tested by CI) others (cross compile for example) not
NOTE
It was harder to make the examples compile (especially on windows), than the actual library.
There are no tests 😓 , so the examples act as those, since if the compile, at least some things are working correctly