feat: add shared runner metadata and centralize runner detection#41
Open
Ishita-190 wants to merge 1 commit intometacall:masterfrom
Open
feat: add shared runner metadata and centralize runner detection#41Ishita-190 wants to merge 1 commit intometacall:masterfrom
Ishita-190 wants to merge 1 commit intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #40
Files changed:
language.ts,package.ts,package.spec.tsIn
language.ts:RunnerunionRunnerInfointerfaceRunnersmap (file patterns, install commands, display name, language mapping)detectRunnersFromFiles(files)helperIn
package.ts:findRunnersnow uses shared detection from language metadataIn
package.spec.ts:detectRunnersFromFilesChecklist:
npm testnpm run lintnpx tsc --noEmitAll tests are working properly:
Note:
findRunnersnow returnsSet<Runner>instead ofSet<string>. Runtime behavior is unchanged.I'll have to modify the following files in https://github.com/metacall/faas to move runner logic to protocol:
package.json– bump protocol dependenciessrc/install.ts– remove duplicated runner definitions and use protocol insteadsrc/app.ts– update runner typing from string[] to runner[]src/repository.ts– use protocol runner detectionsrc/package.ts– validate and parse runners using protocol types