Repository navigation
Reusable vpn authkey - #207
Merged
Merged
Conversation
mwennrich
approved these changes
Oct 21, 2026
Gerrit91
reviewed
Oct 21, 2026
| (buf.validate.field).string.max_len = 512 | ||
| ]; | ||
| // Reusable, if set to true, the authkey can be used multiple times within the expiration window. | ||
| bool reusable = 5; |
Contributor
There was a problem hiding this comment.
Do we really need to add this to the API such that admins can also do this? Or can't this just be done internally for firewalls?
Contributor
Author
There was a problem hiding this comment.
The internal call is:
func (v *vpn) CreateAuthKey(ctx context.Context, req *adminv2.VPNServiceAuthKeyRequest) (*adminv2.VPNServiceAuthKeyResponse, error) {Why should we prevent that an admin can do this ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows firewalls to authenticate multiple times in case of network errors as long as the authkey is not expired.
Used AI-Tools ✨