Skip to content

Fix assignment to nil map #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iljarotar wants to merge 1 commit into from
Closed

Fix assignment to nil map #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/dns/dnscache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,10 @@ func (c *DNSCache) updateIPEntry(qname string, rrs []dnsgo.RR, lookupTime time.T
c.Lock()
defer c.Unlock()

if c.fqdnToEntry == nil {
c.fqdnToEntry = map[string]cacheEntry{}
Copy link
Contributor

@Gerrit91 Gerrit91 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this gets initialized in the constructor? Why does it happen?

Copy link
Author

@iljarotar iljarotar Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a false trail. The stack trace was complaining about a different map.

}

entry, exists := c.fqdnToEntry[qname]
if !exists {
entry = cacheEntry{}
Expand Down