Open
Conversation
| } | ||
|
|
||
| override fun onCreateItem() { | ||
| while (true) { |
There was a problem hiding this comment.
Не рекомендую писать бесконечные циклы через while (true) - лучше всегда явно прописывать условие выхода из цикла, чтобы уменьшить вероятность ошибиться и повысить читабельность кода
Comment on lines
+19
to
+24
| val name = ConsoleReader.readLine("Введите название архива: ") | ||
|
|
||
| if (name.isBlank()) { | ||
| println("Название архива не может быть пустым") | ||
| continue | ||
| } |
There was a problem hiding this comment.
Код для считывания непустой строки с ввода лучше вынести в отдельную функцию - код, разделённый на небольшие функции, легче читать, поддерживать и переиспользовать
Comment on lines
+74
to
+76
| if (choice == items.size - 1) { | ||
| return false // Выход | ||
| } |
There was a problem hiding this comment.
Не стоит в этой функции проверять, является ли опция выходом - это не надёжно. Лучше из items[choice].second.invoke() вернуть какое-нибудь значение, которое бы влияло на выход из программы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
моё 1-е консольное приложение