Validate metashade params refactor (metashade/metashade#244) - #68
Merged
Conversation
Update submodule pointer to metashade params-refactor branch which refactors BSDF input metadata resolution into the Permutation constructor and emits stock nodedef docstrings. Regenerate reference baselines: generic 'Input parameter X' placeholders are replaced with the stock ND_standard_surface_surfaceshader docstrings. Signed-off-by: Pavlo Penenko <pavlo.penenko@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation PR for metashade/metashade#244.
Updates the metashade submodule pointer to the
params-refactorbranch and regenerates reference baselines.Changes
627b04a(params-refactor branch)Input parameter Xdocstrings replaced with stockND_standard_surface_surfaceshaderdocstringsPurpose
Validates that the metashade params refactor (BSDF input metadata resolution moved into
Permutationconstructor, stock docstring propagation) integrates cleanly with the MaterialX render test infrastructure.Working towards metashade/metashade#233.