Explicit float to int typecast - fixes #311#336
Open
Alkl58 wants to merge 1 commit intomewebstudio:masterfrom
Open
Explicit float to int typecast - fixes #311#336Alkl58 wants to merge 1 commit intomewebstudio:masterfrom
Alkl58 wants to merge 1 commit intomewebstudio:masterfrom
Conversation
Alkl58
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the warning:
Reason for this warning is that the
textfunction expects int values for the$xand$ypoints.Since PHP 8.1 this warning notice is emmited, as implicit float -> int conversion is being deprecated.
This PR simply casts the floats to integers explicitly.
Not sure if it would be better to round, floor, or ceil the values?