Skip to content

Loosen the vs-scipy timing ceilings past CI runner noise #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarmey merged 2 commits into from
Sep 19, 2026
Merged

Loosen the vs-scipy timing ceilings past CI runner noise #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a78f33b
Loosen the vs-scipy timing ceilings past CI runner noise
fishidaho Sep 18, 2026
bf1cc2c
Merge branch 'main' into chore/loosen-timing-gate
aarmey Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions benchmarks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ the project guards them.

**Throughput relative to scipy**, never absolute seconds. The same work is
timed through scipy in the same process and the ratio recorded, which cancels
most of the difference between machines. Still the noisiest metric, so its
gate is much looser.
most of the difference between machines. It does not cancel all of it -- a
shared CI runner has measured 5x what a workstation does on the same commit --
so this is much the noisiest metric and its gate is correspondingly loose.

Each case runs in its own subprocess, since measurement state and JIT warm-up
leak between them otherwise.
Expand Down
6 changes: 3 additions & 3 deletions benchmarks/baselines.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"bytes_per_nonzero": 1.1,
"indices_bytes_per_nonzero": 1.1,
"vs_scipy_ratio": 1.1,
"time_ratio_vs_scipy": 4.0,
"time_ratio_vs_scipy": 10.0,
"time_ratio_view_over_materialize": 4.0,
"cpu_ratio_1t_cp10k_log1p": 1.5,
"cpu_ratio_1t_parafac2": 1.5,
Expand All @@ -19,10 +19,10 @@
"vs_scipy_ratio": 0.4751
},
"matvec_vs_scipy": {
"time_ratio_vs_scipy": 1.0
"time_ratio_vs_scipy": 2.5
},
"matmat_vs_scipy": {
"time_ratio_vs_scipy": 1.0
"time_ratio_vs_scipy": 2.5
},
"normalized_cp10k_log1p_matmat_vs_materialize": {
"time_ratio_view_over_materialize": 0.3
Expand Down
Loading