Write live proxies to output file incrementally as they are found

[AlisaLC]

Previously, the output file was only written after all threads finished. Now a shared list and lock are used across threads so the file is written (sorted by ping) each time a live proxy is discovered, making results available immediately during a long-running check.

[mheidari98]

Code review

Found 2 issues:

1. --reuse data loss: when --reuse is set, prior contents of the output file are loaded as candidates to be re-checked. The new write path opens outputFile in 'w' mode (truncating) and rewrites only sharedProxy, which starts empty. As soon as the first live proxy is found, the file is truncated and replaced with that single entry — wiping every previously-saved proxy that has not yet been re-tested. On Ctrl+C mid-run this leaves the user with a strict subset of their reused list. Previously the file was rewritten once at the end after results were merged.

proxyUtil/proxyUtil/v2rayChecker.py

Lines 140 to 144 in 1c46077

	if args.reuse and os.path.isfile(args.output):
	with open(args.output, 'r', encoding='UTF-8') as f:
	lines.update( parseContent(f.read().strip()) )

proxyUtil/proxyUtil/v2rayChecker.py

Lines 49 to 57 in 1c46077

	liveProxy.append((url, ping))
	if sharedProxy is not None and lock is not None and outputFile is not None:
	with lock:
	sharedProxy.append((url, ping))
	sharedProxy.sort(key=lambda x: x[1])
	with open(outputFile, 'w', encoding="utf-8") as f:
	for ss_url in sharedProxy:
	f.write(f"{ss_url[0]}\n")
	else:

2. Full file rewrite + sort under the lock on every live hit: each successful check sorts the entire sharedProxy and rewrites the whole output file while holding the global lock, so file I/O serializes all worker threads. Cost grows O(k²) in live count and contention scales with thread count. Move the I/O outside the lock (e.g. snapshot the list under the lock, write outside), or write incrementally without re-sorting+rewriting from scratch (bisect.insort + atomic temp-file rename).

proxyUtil/proxyUtil/v2rayChecker.py

Lines 49 to 57 in 1c46077

	liveProxy.append((url, ping))
	if sharedProxy is not None and lock is not None and outputFile is not None:
	with lock:
	sharedProxy.append((url, ping))
	sharedProxy.sort(key=lambda x: x[1])
	with open(outputFile, 'w', encoding="utf-8") as f:
	for ss_url in sharedProxy:
	f.write(f"{ss_url[0]}\n")
	else:

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}