⚡ optimize package.json dependency loading

[miccy]

💡 What

This PR implements a performance optimization for the @worms-ctrl/scanner by caching the results of package.json dependency parsing. It also refactors the codebase to unify the injection detection logic, removing a redundant implementation in scan.ts.

🎯 Why

During a scan, package.json was being read and parsed multiple times (once for the main injection detector in scan.ts and potentially again if other detectors were added). Caching this data avoids unnecessary CPU and I/O overhead. Unifying the logic improves maintainability and ensures consistent behavior (e.g., handling of scoped packages).

📊 Measured Improvement

Using a micro-benchmark with 10,000 iterations:

• Baseline: ~0.0346ms per call
• Optimized: ~0.0019ms per call
• Improvement: ~18x faster for cached lookups.

In real-world usage, this eliminates redundant disk reads and JSON parsing per scan run.

✅ Verification Results

• Created and ran new unit tests in packages/scanner/tests/injection.test.ts (3/3 passing).
• Verified performance with packages/scanner/benchmarks/injection.bench.ts.
• Updated CHANGELOG.md.

---

PR created automatically by Jules for task 7256967882447024215 started by @miccy

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 54b3dae9-d0bf-4913-9753-4253649db3ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch perf-optimize-pkg-json-loading-7256967882447024215

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[miccy]

⚠️ Closing as outdated — the unification this PR proposed is already done, and caching needs to be applied to the current architecture.

What was good about this PR:

• Cache (Map) for loadPackageJsonDeps() to avoid redundant I/O
• Unifying injection detection logic

Why it can't be merged:

• detectInjection was already unified: scan.ts imports from detectors/injection.ts (no duplicate)
• Current injection.ts uses a completely different detection model: getPhantomDependencyMatches() + getThreatVersionMatches() from the threat DB — not simple declared-vs-lockfile comparison
• The peerDependencies addition and message changes conflict with current signatures
• CHANGELOG.md entry conflicts with existing entries

The caching optimization could be reimplemented on the current loadPackageJsonDeps() in detectors/injection.ts.