Skip to content

🧪 fix: use testInfo.outputPath for playwright screenshots#27

Merged
miccy merged 2 commits intodev/preview-v2from
fix-playwright-screenshot-paths-2690430341770954550
May 5, 2026
Merged

🧪 fix: use testInfo.outputPath for playwright screenshots#27
miccy merged 2 commits intodev/preview-v2from
fix-playwright-screenshot-paths-2690430341770954550

Conversation

@miccy
Copy link
Copy Markdown
Owner

@miccy miccy commented May 5, 2026

This PR applies Copilot's suggestion to use testInfo.outputPath in Playwright E2E tests instead of hardcoded output paths for screenshots. This change prevents issues during parallel test execution (fullyParallel) and avoids leaving untracked artifacts in the working tree.


PR created automatically by Jules for task 2690430341770954550 started by @miccy

Replaces hardcoded fixed file paths for screenshots with
testInfo.outputPath() in verify-search.spec.ts to prevent
collisions during parallel test execution.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 524d9a23-1452-4550-826f-7c3eaef796a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-playwright-screenshot-paths-2690430341770954550

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@miccy miccy marked this pull request as ready for review May 5, 2026 05:14
@miccy miccy merged commit d5ec3e0 into dev/preview-v2 May 5, 2026
4 of 5 checks passed
@miccy miccy deleted the fix-playwright-screenshot-paths-2690430341770954550 branch May 5, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant