Fix tab ID becoming 0 once the tab contains splits - #4208
Open
4RH1T3CT0R7 wants to merge 1 commit into
Open
Conversation
`Tab` embeds its root `views.Node`, so `tab:ID()` from Lua resolved to `Node.ID()`, which returns 0 for any node that has children. As soon as a tab contained a split its root stopped being a leaf and the id was gone. Give `Tab` its own id, taken from the root node when the tab is created, so it stays the same after splitting. An unsplit tab reports the same value as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tabembeds its rootviews.Node, sotab:ID()in Lua ends up callingNode.ID(). That method returns 0 for any node that has children, and once a tab contains a split its root is no longer a leaf. A plugin that keys anything on the tab id loses track of the tab the moment the user splits it, which is what #4186 reports.Tabnow carries its own id, taken from the root node when the tab is created, andID()returns that. For an unsplit tab the value is the same as before, it just no longer changes after a split. A small test ininternal/actioncovers the split case and checks that two tabs get distinct ids.Fixes #4186