Zlib compression #180
Open
Zlib compression #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lead to double file creation and corrupted files. The lock solves this.
…into zlib-compression
| ELEVEN_BIT_MONOCHROME = 6 | ||
|
|
||
| ZLIB_COMPRESSED = 8 | ||
| NO_COMPRESSION = 1 |
Collaborator
There was a problem hiding this comment.
This seems redundant to UNCOMPRESSED. If NO_COMPRESSION is a standard name, maybe good to remove uncompressed
Collaborator
|
I'd suggest merging this (assuming it passes test). However, my write access to this repository has been removed. Perhaps @nicost or @marktsuchida could merge it? |
Member
|
Thanks, @henrypinkard! That would be the effect of you retiring from the org, but we can add you as a collaborator on specific repos. I've sent an invite. |
Collaborator
|
Thanks @marktsuchida . I still seem to not have permissions to approve running the tests |
Member
|
@henrypinkard Strangely, I don't see a button to approve either. (Never seen "Waiting for status to be reported" before.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the 8bit nd tiff tag bugfix, put_image lock for thread safety, reader optimization (mmap) and zip (zlib) compression.
The compression tag value was chosen to be the same like in tiff specifications (1 for no compression, 8 for zip/zlib compression).
The compression is compatible with standard tiff readers.
For now there are no zlib options (uses zlib standard keys).