feat: propagate sasl.client.callback.handler.class for MSK IAM producers - #306
Abhayanthk wants to merge 4 commits into
Conversation
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
|
What I found:
What I'm going to do:
Backward compatibility: This change is fully backward-compatible. Both callback handler fields are completely optional in the CRD. In the Qute template, they are wrapped in standard This is my first contribution here and I'm still learning the codebase, so if I've put something in the wrong place or missed an existing pattern for SASL config, I'd appreciate any guidance. |
|
While working on this, I noticed I only added the new row and matched the existing style/wording — I didn't touch or rewrite any of the existing documentation. Happy to change the phrasing if you'd prefer it worded differently. |
Signed-off-by: Abhayanth K <abhayanth2006@gmail.com>
- Add saslClientCallbackHandlerClass and saslLoginCallbackHandlerClass to KafkaAuthenticationSpec. - Map these properties to the application.properties Qute template for async-minion. - Wrap properties in optional blocks to maintain backward compatibility. Fixes microcks#305 Signed-off-by: Abhayanth K <abhayanth2006@gmail.com>
- Add saslClientCallbackHandlerClass to the CRD documentation table Signed-off-by: Abhayanth K <abhayanth2006@gmail.com>
f9b9cc1 to
11a7f98
Compare
|
Hi again! I noticed the upstream PR (microcks/microcks#2232) included a unit test for the mapping, so I've added the equivalent coverage here. I added a new test method to This should round out the change — happy to adjust if you'd like the test structured differently. |
Signed-off-by: Abhayanth K <abhayanth2006@gmail.com>
|
Hi @lbroudoux 👋 — this is ready for review whenever you get a chance. I’ve added the full thought process, the fix, and my reasoning in the comments above, so you can read through it there. |
Description
This PR propagates
kafka.sasl.client.callback.handler.classso async-minion Kafka producers can properly authenticate against Amazon MSK using IAM.Key Changes:
saslClientCallbackHandlerClass(and the previously missingsaslLoginCallbackHandlerClass) to theKafkaAuthenticationSpecCRD, and safely mapped them into theapplication.propertiesQute template.{#if}blocks in the template, ensuring zero impact on existing non-MSK deployments.microcks-cr.mdto officially document the new client callback handler.AsyncMinionConfigMapDependentResourceTestto verify that the Operator correctly renders the new properties into the generated ConfigMap.Related issue(s)
Fixes #305
AI Usage Disclosure: Portions of the code and documentation in this PR were generated and refined with the assistance of an AI coding assistant. All changes have been reviewed and understood by me, and I am fully accountable for them.