Auth: Fix AskPermission consent flow#3437
Open
DaVinci9196 wants to merge 1 commit intomicrog:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After clicking Allow, callers using startActivityForResult got RESULT_CANCELED and kept retrying getToken in a tight loop
(e.g. Wongnai sign-in stuck looping).
onAllow/onDeny now call setResult on the UI thread before finish.
Also fixes short OIDC scopes (email, profile) showing as "unknown" instead of the ConsentData title, and the consent screen text being unreadable in dark mode.