revert: remove fix-forward instructions from PR #786 (#926)#1009
Closed
revert: remove fix-forward instructions from PR #786 (#926)#1009
Conversation
The fix-forward scan (review-responder) and self-review checklist (issue-implementer) added in PR #786 had no measurable impact after 8 days and 79 merged PRs. The responder ignores the instructions entirely, continuing to react to individual comments rather than scanning proactively. Remove the dead prompt weight. Closes #926 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reverts previously added agent prompt instructions (fix-forward scan and implementer self-review checklist) from the GitHub agent workflow markdowns, reducing prompt length/token cost after evidence showed no measurable effect on agent behavior.
Changes:
- Removed the “Fix-forward scan” step from
review-responder.mdand renumbered remaining steps. - Removed the “Self-review before pushing” checklist block from
issue-implementer.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/review-responder.md | Removes the fix-forward scan instruction and renumbers the remaining responder steps. |
| .github/workflows/issue-implementer.md | Removes the implementer self-review checklist block to reduce prompt overhead. |
Owner
Author
|
Closing — deferring this change pending cross-repo investigation. See findings report on #926. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the fix-forward scan and self-review checklist instructions added in PR #786. These had no measurable impact on agent behavior.
Evidence
Review-responder fix-forward scan (from issue #926):
is_dir()OSError guard in_full_scandir_discovery(#846) #852, test(render_detail): cover untested_build_event_detailsbranches (#860) #865 showed the responder ignoring the scan entirelyIssue-implementer self-review checklist (fresh analysis):
parse_eventsto_parse_events_from_offset(#987) #989 (8 rounds): 5 stale docstrings — a literal checklist item, not caughtimplementation.mdinaccuracies and documentation gaps (#952) #953 (5 rounds): inaccurate doc descriptions — a literal checklist item, not caughtChanges
review-responder.md: Removed fix-forward scan step, renumbered remaining stepsissue-implementer.md: Removed self-review checklist blockNet: -19 lines of prompt text that added token cost with zero behavioral effect.
Closes #926