This repository was archived by the owner on Dec 5, 2023. It is now read-only.
Open
Conversation
added 2 commits
May 16, 2022 14:48
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
Signed-off-by: Pete Stevenson <jps@pixielabs.ai>
philkuz
suggested changes
Nov 22, 2022
philkuz
left a comment
philkuz
left a comment
There was a problem hiding this comment.
Hi Pete, revisiting this now and I think you fell into a trap that I fell into as well. Your current diff won't work on a fresh repo: the JRE that's defined in the Dockerfile docker/carts/Dockerfile would not run anything compiled by this JDK. The JRE is version 11 while you're compiling 18.
The issue is because maven will not build anything if target exists and target is gitignored by this repo. So you probably just used the first result (the JDK 11 result) and that got uploaded into your container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pete Stevenson jps@pixielabs.ai