Skip to content

Updating hash function for MsalAuth._client_credential_cache #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rodrigobr-msft wants to merge 1 commit into from
Closed

Updating hash function for MsalAuth._client_credential_cache #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es/microsoft-agents-authentication-msal/microsoft_agents/authentication/msal/msal_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def _create_client_application(
cert = load_pem_x509_certificate(
data=bytes(public_certificate, "UTF-8"), backend=default_backend()
)
thumbprint = cert.fingerprint(hashes.SHA1()).hex()
thumbprint = cert.fingerprint(hashes.SHA256()).hex()
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the certificate thumbprint hash from SHA-1 to SHA-256 changes both the value and length (40 hex chars -> 64). Since this value is passed to MSAL as the client_credential['thumbprint'], please verify MSAL/AAD expects a SHA-256 thumbprint here; if MSAL is still using the x5t (SHA-1) header/claim, this will break certificate-based authentication. If SHA-256 is the goal, consider using the MSAL-supported field/claim for SHA-256 (e.g., x5t#S256 / a dedicated thumbprint_sha256 parameter) or providing both where supported.

Copilot uses AI. Check for mistakes.

self._client_credential_cache = {
"thumbprint": thumbprint,
Expand Down
Loading