Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the DeltaMetricReader unit test to remain compatible with a newer OpenTelemetry metrics data structure by validating output via the shared telemetry helper used throughout the test suite.
Changes:
- Replace manual
resource_metrics/scope_metrics/metricsshape assertions withfind_metric(...)usage in the compatibility test. - Keep validating the returned
Metricand datapoint fields (data_points,value,attributes) expected by the helper utilities.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
axelsrz
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an updated version of OTEL, aunit test for the internal DeltaMetricReader fails. This fixes that by reusing one of the utility functions during that test.