-
Notifications
You must be signed in to change notification settings - Fork 375
Add VAT rate resolution and VAT amount difference for E-Document purchases #8251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ventselartur
merged 71 commits into
main
from
private/ventselartur/PayablesAgentVATSpike
May 24, 2026
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
79657ea
new doc with issue and concerns
ventselartur 3baca49
save plans
ventselartur 98fae1a
update plans
ventselartur 31a7c57
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
ventselartur b8fb566
fix: normalize ADI tax data to VAT percentage in E-Document Purchase …
ventselartur 34b2207
feat: add [BC] VAT Prod. Posting Group field to E-Document Purchase Line
ventselartur 47c64e8
feat: add VAT Prod. Posting Group column to E-Document draft subform
ventselartur dbb35b7
feat: add VAT Rate Mismatch notification type and handlers
ventselartur e0dd7f7
feat: resolve VAT Prod. Posting Group from extracted VAT rate during …
ventselartur 4bfea7d
feat: apply resolved VAT Prod. Posting Group when creating purchase i…
ventselartur 5d4b175
test: add integration tests for VAT Posting Group resolution during P…
ventselartur f6c8e55
style: sort using statements alphabetically in PreparePurchaseEDocDraft
ventselartur 91447d6
docs: add design spec for VAT rate mismatch inline warning field
ventselartur a89ec5c
docs: update OnValidate logic to compare VAT % from setup against ext…
ventselartur b634ab3
docs: use exact VAT % comparison and handle zero-rate lines in OnVali…
ventselartur 8a0a6d7
docs: add OnLookup trigger to open VAT Posting Setup filtered by vendor
ventselartur 05edca8
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
ventselartur ac58f63
docs: filter VAT matching to Normal VAT and Reverse Charge VAT only
ventselartur 31784c7
docs: add 7 new test cases for VAT calculation type filtering and OnV…
ventselartur 72373db
docs: add implementation plan for VAT rate mismatch inline warning field
ventselartur 0c0ed31
feat: add VAT Rate Mismatch field and OnValidate/OnLookup to VAT Prod…
ventselartur 1bb68d8
refactor: set VAT Rate Mismatch flag instead of notification in Prepa…
ventselartur 9e9d974
feat: add inline VAT warning column to draft subform page
ventselartur b745f53
refactor: remove VAT Rate Mismatch notification infrastructure
ventselartur 307a1de
test: update VAT resolution tests to assert mismatch flag instead of …
ventselartur b0e91be
test: add tests for VAT Calculation Type filtering in Prepare Draft
ventselartur da77a1c
test: add OnValidate mismatch re-evaluation tests
ventselartur 4f497cd
add minor changes
ventselartur 886c294
refactor: move VAT tests to dedicated E-Doc Purch. VAT Tests codeunit
ventselartur bb35470
remove PayablesAgentVATIssue.md
ventselartur 074152d
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
ventselartur eb04ce2
remove docs
ventselartur f3f27b9
add total line to the draft
ventselartur e9360b6
merge from master with manual resolve
ventselartur 8f1d64e
resolve conflicts
ventselartur bc5d54d
fix EDocPurchVATTests.Codeunit.al
ventselartur 7c5f77e
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
ventselartur ad40024
make total line amount not editable
ventselartur 5a34323
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
ventselartur 3caf30f
[E-Document] Substitute Standard Purchase Order with Omit Last Line a…
ventselartur c96a46d
feat(edoc): add LogVATRateMismatch on E-Document Purchase Line
ventselartur 0604d4f
feat(edoc): log VAT mismatch from line OnValidate
ventselartur fb6df3a
feat(edoc): log VAT mismatch from ResolveVATProductPostingGroups
ventselartur 1d41664
swamp company and vendor fields in EDocStandardPurchaseOrder.Report.al
ventselartur ddfcd2a
update for LogVATRateMismatch
ventselartur 35cdfac
align EDocStandardPurchaseOrder.Report.al
ventselartur fc4e7aa
update
ventselartur 39a9379
VAT amount diff
ventselartur 20f51b0
update the page
ventselartur 2e8171c
revert header to line inconsistency. part 1
ventselartur eee3358
remove remaining referenes to the header to lines inconsistency
ventselartur a826a76
merge from main
ventselartur 224dba0
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
ventselartur 0582b39
replace direct validation of VAT Product Posting group to the one wit…
ventselartur 98e9df4
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
ventselartur 2cc30fd
removeing unnecessary things
ventselartur 9db4a01
add resolve VAT product posting group option
ventselartur 8e9474d
add new options
ventselartur 73a0312
remove unnecessary changes
ventselartur 36d5570
remove more changes
ventselartur 13c97d3
refactoring
ventselartur 63562f7
Remove personal .claude symlinks
ventselartur 84dab51
add change to EDocumentUpgrade.Codeunit.al
ventselartur fc69473
code review
ventselartur 6e09338
code review
ventselartur 2b2feee
replace VAT diff field with a variable on the page
ventselartur b243550
merge with confilict resolution
ventselartur a7c501a
fix test codeunit id to avoid conflict
ventselartur 2e01735
code review
ventselartur d37d81c
add telemetry tag
ventselartur b9392a3
update id in the app.json
ventselartur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.