(Bug 635870): [Subcontracting] Rename "Subcontracting Inbound Whse. Handling Time" to "Subcontracting Component Transfer Lead Time"#8284
Open
alexei-dobriansky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#635870
Summary
Renames Manufacturing Setup field
99001505(owned by the Subcontracting app) to remove misleading terminology borrowed from the base Location Card field "Inbound Whse. Handling Time". The Subcontracting field has fundamentally different semantics — it is a backward-calculated planning lead time subtracted from the prod-order component due date to schedule transfer-order arrival at the subcontractor, not a forward-calculated put-away time.Why the old name was wrong
Changes
Manufacturing Setup field 99001505:
"Subc. Inb. Whse. Handling Time""Subc. Comp. Transfer Lead Time"(30 chars)Subcontracting Inbound Whse. Handling TimeSubcontracting Component Transfer Lead TimePublic API in
codeunit 99001505 "Subcontracting Management":CalcReceiptDateFromProdCompDueDateWithInbWhseHandlingTime→CalcReceiptDateFromProdCompDueDateWithCompTransferLeadTimeInternal helpers in
codeunit "Subcontracting Comp. Init."renamed for consistency:DefaultInboundWhseHandlingTimeLbl→DefaultCompTransferLeadTimeLblGetDefaultInboundWhseHandlingTime→GetDefaultCompTransferLeadTimeFiles touched
App/src/Setup/Tables/SubcManufacturingSetup.TableExt.alApp/src/Setup/Pages/SubcManufacturingSetup.PageExt.alApp/src/Process/Codeunits/SubcontractingManagement.Codeunit.alApp/src/Process/Reports/SubcCreateTransfOrder.Report.alApp/src/Install/SubcontractingCompInit.Codeunit.alTest/src/Codeunits/Tests/SubcSubcontractingTest.Codeunit.alCompatibility
Breaking change for any extension binding to the old field identifier or the renamed public procedure. Acceptable because the Subcontracting app is a not-yet-released feature.
Related
Part of the broader Subcontracting terminology cleanup alongside bug 633674 (Subcontracting Type → Component Supply Method, Transfer → Transfer to Vendor).