Skip to content

Add webchat-html-tests skill#5840

Merged
OEvgeny merged 3 commits into
mainfrom
skill/webchat-html-tests
Jun 9, 2026
Merged

Add webchat-html-tests skill#5840
OEvgeny merged 3 commits into
mainfrom
skill/webchat-html-tests

Conversation

@OEvgeny

@OEvgeny OEvgeny commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Fixes #

Changelog Entry

Not required for this PR because it only adds contributor tooling.

Description

Adds a new webchat-html-tests skill for Bot Framework Web Chat contributors working on the HTML Selenium Grid test harness. The skill is a renamed copy of the earlier run-and-debug workflow, but now splits the operational commands into bundled scripts and moves the long-form troubleshooting guidance into reference docs.

Design

The skill body stays small for progressive loading, while the scripts and references carry the heavier operational details. The validation pass used the new scripts to start Docker, wait for Selenium Grid readiness, run a focused HTML test, and clean leaked sessions.

Specific Changes

  • Added the webchat-html-tests skill with a more specific name and a keyword-rich description.

  • Split Docker, Jest, and Selenium session management into bundled shell and Python scripts.

  • Moved test architecture notes and failure recovery guidance into separate reference docs.

  • Hardened the Selenium readiness script after a real startup ConnectionResetError during validation.

  • I have added tests and executed them locally

  • I have updated CHANGELOG.md

  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copilot AI review requested due to automatic review settings June 8, 2026 22:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new contributor-facing webchat-html-tests skill to streamline running and debugging the __tests__/html2 Selenium Grid HTML test harness, with operational steps moved into bundled scripts and longer troubleshooting guidance moved into reference docs.

Changes:

  • Added the webchat-html-tests skill entry and procedure doc.
  • Introduced helper scripts to start the Docker/Selenium Grid stack, wait for readiness, run HTML tests, and clean leaked sessions.
  • Added reference docs describing the HTML test architecture and common failure/snapshot recovery workflows.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/skills/webchat-html-tests/SKILL.md Skill definition and streamlined procedure for running/debugging HTML tests.
.github/skills/webchat-html-tests/scripts/start-grid.sh Scripted Docker Compose build/up workflow for Selenium Grid + webchat2.
.github/skills/webchat-html-tests/scripts/wait-for-grid.py Polls Selenium Grid status until ready.
.github/skills/webchat-html-tests/scripts/run-html-tests.sh Wrapper for running Jest HTML tests (optionally scoped + snapshot update).
.github/skills/webchat-html-tests/scripts/cleanup-grid-sessions.py Attempts to delete busy Selenium sessions to prevent grid stalls.
.github/skills/webchat-html-tests/references/architecture.md Reference doc on test layout and regex targeting patterns.
.github/skills/webchat-html-tests/references/failure-modes.md Reference doc on common failures and snapshot update workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/skills/webchat-html-tests/scripts/cleanup-grid-sessions.py Outdated
Comment thread .github/skills/webchat-html-tests/scripts/cleanup-grid-sessions.py Outdated
Comment thread .github/skills/webchat-html-tests/scripts/wait-for-grid.py
@OEvgeny OEvgeny merged commit aa7d0fd into main Jun 9, 2026
32 checks passed
@OEvgeny OEvgeny deleted the skill/webchat-html-tests branch June 9, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants